Commit Graph

3517 Commits (090945d8a8017e0f2b84aa8123f6ae00ea66af87)

Author SHA1 Message Date
Johannes Pfeifer 090945d8a8 Use namespace for identification and sensitivity 2023-12-13 17:51:49 +01:00
Sébastien Villemot 1c10a3acbf
Enable performance-* checks in clang-tidy 2023-12-13 16:30:40 +01:00
Sébastien Villemot cbfad751c8
Remove some unnecessary temporary std::string allocation
Automatically detected by clang-tidy using
performance-inefficient-string-concatenation check.

Several of the detected cases are left unattended, because the syntax is more
elegant as it is, and they are not performance-critical.
2023-12-13 16:29:46 +01:00
Sébastien Villemot b31de3d9a6
Pre-allocate std::vector instances filled from loops
Automatically detected by clang-tidy using
performance-inefficient-vector-operation check.
2023-12-13 16:19:51 +01:00
Sébastien Villemot 22675728aa
No longer call std::move on trivially-copyable types
Automatically detected by clang-tidy with performance-move-const-arg check.

Do not make the modification for Tokenizer::location type, since we have no
guarantee that the type will remain trivially-copyable in the future.
2023-12-13 15:37:07 +01:00
Sébastien Villemot 7cfe226e58
When possible, use a more efficient overload of std::string::find()
Automatically detected by clang-tidy using the performance-faster-string-find
check.
2023-12-13 14:21:11 +01:00
Sébastien Villemot d635aac04a
Turn some loop variables into const references when possible
Automatically detected by clang-tidy using performance-for-range-copy check.
2023-12-13 14:21:09 +01:00
Sébastien Villemot 3d94f1956c
Remove some unneeded object copies
Automatically detected by clang-tidy using performance-unnecessary-value-param
check.
2023-12-13 10:28:54 +01:00
Sébastien Villemot cd86b1895d
Configuration file: new default value for GlobalInitFile option
If the user did not specify the GlobalInitFile option, use global_init.m in configuration
directory if it exists.
2023-12-12 16:01:54 +01:00
Sébastien Villemot 1de83b7b12
Configuration file: simplify handling of GlobalInitFile option
There was some overengineering related to the Hook class.
2023-12-12 15:54:57 +01:00
Sébastien Villemot 328e8eef78
Change default location for configuration file
– under Linux and macOS, use the “dynare” subdirectory of the configuration
  directory specified by the XDG specification
– under Windows, use the “dynare” subdirectory of the Application Data folder

The old location is kept for backward compatibility, with a warning.
2023-12-12 12:28:33 +01:00
Sébastien Villemot 7c83b81623
Turn some configuration-related classes into nested classes 2023-12-11 17:32:30 +01:00
Sébastien Villemot 4389e5320d
Rename files, classes and variables in relation to the configuration file
In particular, makes clearer the distinction between configuration and
configuration file. The former includes information that is not in the
latter (command-line options.)
2023-12-11 17:17:57 +01:00
Sébastien Villemot 7dd125e43a
Remove duplicate definition of expr_t 2023-12-11 14:29:43 +01:00
Sébastien Villemot e4b23fecb0
Update comments in relation to implicit conversion from std::filesystem::path to std::string
There is actually no bug in MinGW. The different behaviour under Windows is
expected, because the implicit conversion there is only to std::wstring.
2023-12-08 18:39:27 +01:00
Sébastien Villemot 4790fa00d8
Remove workaround for bug in MinGW compiler
It would mishandle trailing slashes or backslashes in std::filesystem::path, see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88881

The bug is now fixed in the version of MinGW in Debian “bookworm” 12.

Ref. Madysson/estimation-codes#11
2023-12-08 18:36:25 +01:00
Sébastien Villemot 378d00fc3a Merge branch 'globals' into 'master'
Remove globals from dynare_sensitivity and dynare_identification

See merge request Dynare/preprocessor!95
2023-12-07 11:03:06 +00:00
Sébastien Villemot 045fbaec0e
Remove empty line
[skip ci]
2023-12-04 17:36:20 +01:00
Sébastien Villemot bffd68e0bf
Add a clang-tidy configuration file
Also add some annotations to remove some false positives.

There remain some boost-related false positives, it’s unclear how to suppress
them.
2023-12-04 16:37:00 +01:00
Johannes Pfeifer 6d9fc367d0 Remove globals from dynare_sensitivity and dynare_identification 2023-12-04 12:01:19 +01:00
Sébastien Villemot b2e9ec205e
No longer use reserved identifiers for include guards
Automatically detected using clang-tidy with bugprone-reserved-identifier
check.

By the way, homogeneize the define identifiers in relation to camel case
convention.
2023-12-01 15:39:01 +01:00
Sébastien Villemot 5af38c8ced
ModelTree.hh: fix misplaced #endif for include guard 2023-12-01 15:35:40 +01:00
Sébastien Villemot c2d6ab8ee0
Simplify a few loops using std::ranges::reverse_view
Automatically detected using clang-tidy with modernize-loop-convert check.
2023-12-01 15:06:40 +01:00
Sébastien Villemot c5cc61b110
PlannerObjectiveStatement: turn model_tree into a std::unique_ptr
Avoids an unnecessary copy.
2023-12-01 14:59:20 +01:00
Sébastien Villemot 5e89921ea1
Use emplace() and emplace_back() at several places
Automatically detected using clang-tidy with modernize-use-emplace check.
2023-12-01 14:30:03 +01:00
Sébastien Villemot b8c521be31
Mark SymbolTable::maxID() as const and nodiscard 2023-12-01 14:17:12 +01:00
Sébastien Villemot 7e6abc97c4
Add [[nodiscard]] attribute to various functions
Automatically detected using clang-tidy with modernize-use-nodiscard check.
2023-12-01 14:14:44 +01:00
Sébastien Villemot 5332c12ab7
Remove unused constructor and data member 2023-12-01 12:09:59 +01:00
Sébastien Villemot 0295c389a2
CI: add job that checks formatting with clang-format 2023-11-30 16:37:35 +01:00
Sébastien Villemot b6adff7de7
Manually reformat Flex and Bison files to be closer to clang-format style 2023-11-30 16:21:34 +01:00
Sébastien Villemot d463607e90
Reformat C++ source code using clang-format 15 2023-11-30 15:58:32 +01:00
Sébastien Villemot 529ec50337
clang-format configuration: set “PackConstructorInitializers: NextLine” 2023-11-30 15:28:43 +01:00
Sébastien Villemot 6ed53ae0fc
clang-format configuration: never collapse short functions on a single line
[skip ci]
2023-11-29 19:17:59 +01:00
Sébastien Villemot 3e415c06b5
CI: enable FF_ENABLE_BASH_EXIT_CODE_CHECK to avoid unintuitive behaviour with && operator 2023-11-23 12:27:05 +01:00
Sébastien Villemot 73be95423d
Bump minimal required version of MATLAB to R2018b
Ref. dynare#1907
2023-11-22 12:06:34 +01:00
Sébastien Villemot c4c14963a1
Add clang-format config file for formatting C++ code 2023-11-21 12:44:44 +01:00
Sébastien Villemot 46aa6610ab
model_replace, model_remove: allow selecting an equation with several (conjunct) tags
NB: does not (yet) works with Occbin regime-specific equations.

Ref. dynare#1890
2023-11-15 12:05:06 +01:00
Sébastien Villemot 661b16440e Merge branch 'doc' into 'master'
preprocessor.tex: add slides on verbatim block and command line options

See merge request Dynare/preprocessor!94
2023-11-15 10:24:01 +00:00
Johannes Pfeifer 09a9a4e9b6 preprocessor.tex: add slides on verbatim block and command line options 2023-11-15 10:25:12 +01:00
Sébastien Villemot 1ad7dd9672
Refactor parsing of equation tags in a more functional way
Incidentally, makes tag names case-insensitive in “model_replace” and
“model_remove”, which is consistent with tag declarations.
2023-11-14 15:55:30 +01:00
Sébastien Villemot ac35ef6101
Error out if an “initval” block appears after an “endval” block (without the “learnt_in=…” option)
Closes: #104
2023-11-14 14:28:30 +01:00
Sébastien Villemot cffbb0f4fd Merge branch 'doc' into 'master'
preprocessor.tex: further updates

See merge request Dynare/preprocessor!93
2023-11-14 13:02:15 +00:00
Johannes Pfeifer 74bb394f4c preprocessor.tex: further updated 2023-11-14 13:06:45 +01:00
Sébastien Villemot 9caacb194b Merge branch 'doc' into 'master'
preprocessor.tex: modernizations and typo corrections

See merge request Dynare/preprocessor!92
2023-11-13 17:01:50 +00:00
Johannes Pfeifer 4a2167e811 preprocessor.tex: modernizations and typo corrections 2023-11-13 17:56:53 +01:00
Sébastien Villemot b58ab55e97
Drop obsolete and undocumented stoch_simul options: dr_algo, simul, simul_algo, simul_seed 2023-11-10 15:22:35 +01:00
Sébastien Villemot 63f04636ee
New structure M_.block_structure.block().bytecode_jacobs_cols_to_sparse
It maps column indices in the Jacobian returned by bytecode MEX in evaluate
mode (which only contains nonzero columns, but also incorporate recursive
variables), into column indices in the sparse representation (which has 3×n
columns for two-boundaries blocks and n columns for one-boundary blocks).
Columns unused in the sparse representation are indicated by a zero.
2023-11-07 15:32:12 +01:00
Sébastien Villemot 086d65d98c
Remove unused enum values 2023-11-07 15:32:12 +01:00
Sébastien Villemot 53987fc039
Block: more symmetry between bytecode and non-bytecode write helpers 2023-11-07 15:32:12 +01:00
Sébastien Villemot 66dcb59d2b
🐛 Bytecode: fix FSTPG3_::get_lag()
It would return an incorrect result. This had no impact except for debugging
information.
2023-11-07 15:32:12 +01:00