Commit Graph

6956 Commits (a32e2f165a08af9af8d55943eadb70eb121f9a9d)

Author SHA1 Message Date
Houtan Bastani a32e2f165a get_companion_matrix: remove unnecessary conditional 2018-09-12 18:29:07 +02:00
Houtan Bastani e9d7f6ca24 Merge branch 'master' into ecb-master 2018-09-12 18:28:47 +02:00
Stéphane Adjemian(Charybdis) 6815624a6a Fixed bug.
Growth neutrality correction was applied twice.
2018-09-12 15:41:07 +02:00
Sébastien Villemot 51416bf2ae Always use "isoctave" for testing Octave context 2018-09-07 17:22:08 +02:00
Stéphane Adjemian(Charybdis) 0f3678ec4a Fixed ordering of variables in error correction term of PAC equation
PAC equation has to be written as

diff(x) = a0*(xstar(-1)-x(-1)) + a1*diff(x(-1)) + ... + ap*diff(x(-p)) + PAC_EXPECTATION(pacmodelname) + ...;

In the error correction term, a0*(xstar(-1)-x(-1)), we must have the difference
between the target (the trend xstar(-1)) and the level of the endogenous
variable (x(-1)). To ensure stability around the trend, the parameter a0 needs
to be positive.

REMARKS

 [1] In the TREND_COMPONENT_MODEL the error correction terms are written in
 reverse order, ie as the difference betwwen the level of the endogenous
 variable and the trend variable.

 [2] In the estimation routine we do not constrain a0 to be positive, but is
 would surely help to satisfy this condition in the initial condition.
2018-09-06 22:07:31 +02:00
Stéphane Adjemian(Charybdis) 74ef4d2131 Cosmetic change. 2018-09-06 13:40:43 +02:00
Stéphane Adjemian(Charybdis) 5d8a1feda4 Fixed regular expression.
Data matrices were not correcty lagged for lags>1. This commit fixes the
inconsistencies (in terms of residuals) between Iterative OLS and NLS routines.
2018-09-06 13:40:27 +02:00
Stéphane Adjemian(Charybdis) 940c970ff3 Use same range in NLS and Iterative OLS.
The range option is the range of data considered for the right hand side variable.
2018-09-04 09:40:47 +02:00
Stéphane Adjemian(Charybdis) 6e1d06bddc Display SSR in Iterative OLS. 2018-09-03 18:01:59 +02:00
Stéphane Adjemian(Charybdis) 8b1b1273c3 Fixed correction for growth neutrality.
Also added the possibility to use an endogenous variable for growth.
2018-09-03 17:57:10 +02:00
Stéphane Adjemian(Charybdis) fde103d5f4 Removed debugging display. 2018-09-03 17:55:55 +02:00
Stéphane Adjemian(Charybdis) a207550680 Fixed error correction term. 2018-09-03 17:53:01 +02:00
Stéphane Adjemian(Charybdis) 044f0f8de6 Added missing output required by some integration tests. 2018-09-03 17:38:09 +02:00
Stéphane Adjemian(Charybdis) 5ea0c8098b Ensure that the ordering of the trend variables is consistent...
... With the ordering of the EC variables.
2018-09-03 17:35:59 +02:00
Stéphane Adjemia (Scylla) e1b2b80d64 Small efficiency change. 2018-08-29 17:42:49 +02:00
Stéphane Adjemia (Scylla) d23d1a470b Added the possibility to estimate PAC_EQUATION with iterative ols and non constant growth. 2018-08-29 17:42:04 +02:00
Stéphane Adjemia (Scylla) 30b34c4323 Small efficiency changes. 2018-08-29 16:15:52 +02:00
Stéphane Adjemia (Scylla) 00498d19c8 Fixed ec matrix (rules out lag>1). 2018-08-28 19:25:05 +02:00
Stéphane Adjemia (Scylla) 36388ce28a Fixed bug in PAC_EXPECTATION.
The selection of the target variable in the error correction term was still
wrong if the target variable was not an auxiliary variable.
2018-08-28 19:23:35 +02:00
Stéphane Adjemia (Scylla) 18a2626543 Fixed bugs in PAC_EXPECTATION.
- The selection of the target variable in the error correction term was wrong.
 - Target variables in logs were still not working.
2018-08-28 12:12:21 +02:00
Stéphane Adjemia (Scylla) 6dc35c676b Fixed bug in VAR_EXPECTATION with TREND_COMPONENT_MODEL.
The selection of the expected variable in the companion VAR was not correct.
2018-08-28 11:06:20 +02:00
Stéphane Adjemia (Scylla) ae530293c5 Fixed bug. Trends in log where not accounted for in PAC equation. 2018-08-27 19:35:33 +02:00
Stéphane Adjemia (Scylla) 83c9b0d5b6 Make rool for trend_component_model in var_expectation.
Not yet working, a bug in the preprocessor remains to be fixed. The
preprocessor does not create the correct number of reduced form parameters
for VAR_EXPECTATION when the auxiliary model is a trend component model,
because it ignores the fact that the model has to be rewritten in levels.
2018-08-27 14:37:26 +02:00
Houtan Bastani 6ec9758313 update var_expectation code and tests for change in field name 2018-08-23 10:38:39 +02:00
Stéphane Adjemia (Scylla) cd05b9ba8f Cosmetic changes. 2018-08-22 11:49:30 +02:00
Stéphane Adjemia (Scylla) 2b6ee881a4 Efficiency changes. 2018-08-22 11:49:15 +02:00
Stéphane Adjemia (Scylla) 442a70e905 Added missing semicolon. 2018-08-21 21:56:01 +02:00
Stéphane Adjemia (Scylla) 4a0b3ffe7e Adapted matlab code to new TREND_COMPONENT auxiliary model. 2018-08-21 21:49:58 +02:00
Stéphane Adjemia (Scylla) 38b2593e31 Efficiency changes. 2018-08-21 21:02:20 +02:00
Houtan Bastani 322682635f get_ar_ec_matrices: fix bug in ordering of ec matrix 2018-08-20 14:58:52 +02:00
Houtan Bastani b27267da9b get_ar_ec_matrices: changes for introduction of trend_component_model statement 2018-08-20 10:57:26 +02:00
Stéphane Adjemia (Scylla) 7d6296f7a6 Fixed bug introduced by 42bba08887. 2018-08-17 21:42:09 +02:00
Stéphane Adjemia (Scylla) e50bb1566e Updated dseries submodule. 2018-08-16 16:42:25 +02:00
Stéphane Adjemian(Charybdis) 822446c043 Added missing copyright headers. 2018-08-15 22:05:47 +02:00
Stéphane Adjemian(Charybdis) 42bba08887 Make the code robust to the order of declaration of the estimated parameters. 2018-08-15 22:03:33 +02:00
Stéphane Adjemian(Charybdis) 15ad3cebcf Fixed indexation bug (last autoregressive parameter was missing). 2018-08-15 22:03:01 +02:00
Stéphane Adjemian(Charybdis) 702e6d4cc7 Fixed lag number in PAC equation.
The number of autoregressive parameters has to be equal to the number of lags
in the PAC equation.
2018-08-13 12:41:37 +02:00
Stéphane Adjemian(Charybdis) 8b3ba814c7 Fixed PAC index for target variable in companion VAR. 2018-08-10 15:42:13 +02:00
Stéphane Adjemian(Charybdis) 8a6d23f471 Merge branch 'master' into ecb-master 2018-08-10 15:37:26 +02:00
Stéphane Adjemian(Charybdis) 451385774b Cosmetic changes. 2018-08-10 15:36:41 +02:00
Stéphane Adjemian(Charybdis) 86445832fd Added routine returning true iff a variable is an auxiliary variable. 2018-08-10 14:52:22 +02:00
Stéphane Adjemian(Charybdis) c28c8187e8 Fixed typo. 2018-08-08 16:23:15 +02:00
Stéphane Adjemian(Charybdis) 8033b2737e Added routines for VAR_EXPECTATION_MODEL. 2018-08-08 15:53:55 +02:00
Stéphane Adjemian(Charybdis) c9a38c4de7 Merge branch 'master' into ecb-master
Fixed conflicts:
 - tests/run_block_byte_tests_octave.m
2018-08-04 21:08:08 +02:00
Stéphane Adjemian(Charybdis) 5b30ed34ae Allow calls to get_companion_matrix routine with only one argument. 2018-08-04 20:15:52 +02:00
Stéphane Adjemian(Charybdis) dc026329a7 Cosmetic change. 2018-08-04 20:14:28 +02:00
Sébastien Villemot 13526bcbce Octave now has the same graphical waitbar as MATLAB (for MCMC progress) 2018-08-02 15:33:18 +02:00
Sébastien Villemot d03cc56587 solve_algo=7 and stack_solve_algo=2 are now allowed under Octave
The gmres() function has been implemented (actually since Octave 3.4.1!).
2018-08-02 15:20:39 +02:00
Sébastien Villemot fda021855c Fix forecast command with deterministic exogenous and linear option
Closes #1608
2018-08-02 14:20:51 +02:00
Stéphane Adjemian(Charybdis) f830fb7d53 Updated dseries submodule. 2018-07-31 12:55:17 +02:00