stepan
/
preprocessor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

estimated_params*: add a check that prevents (apparently) recursive prior definitions 

Closes: #77
pac-components
Sébastien Villemot 2021-09-08 17:06:10 +02:00
parent 62ba9a434a
commit cb19ece049
No known key found for this signature in database
GPG Key ID: 2CECE9350ECEBE4A
1 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/ComputingTasks.cc
View File

@ -20,6 +20,8 @@
#include <cassert>
#include <iostream>
#include <sstream>
#include <algorithm>
#include <iterator>
using namespace std;
@ -1401,6 +1403,41 @@ AbstractEstimatedParamsStatement::commonCheckPass() const
}
}
}
/* Check that a parameter declared in this block is not used in expressions
associated to other parameters in the same block (see issue #77) */
// First compute the symbol IDs of parameters declared in this block
set<int> declared_params;
transform(already_declared.begin(), already_declared.end(), inserter(declared_params, declared_params.end()),
[&](const string &name) { return symbol_table.getID(name); });
// Then look for (apparently) recursive definitions
for (const auto &it : estim_params_list)
{
set<int> used_params;
it.init_val->collectVariables(SymbolType::parameter, used_params);
it.low_bound->collectVariables(SymbolType::parameter, used_params);
it.up_bound->collectVariables(SymbolType::parameter, used_params);
it.mean->collectVariables(SymbolType::parameter, used_params);
it.std->collectVariables(SymbolType::parameter, used_params);
it.p3->collectVariables(SymbolType::parameter, used_params);
it.p4->collectVariables(SymbolType::parameter, used_params);
it.jscale->collectVariables(SymbolType::parameter, used_params);
vector<int> intersect;
set_intersection(declared_params.begin(), declared_params.end(),
used_params.begin(), used_params.end(),
back_inserter(intersect));
if (intersect.size() > 0)
{
cerr << "ERROR: in `" << blockName() << "' block, the value of estimated parameter "
<< symbol_table.getName(intersect[0]) << " is used in the declaration for ";
if (it.type == 3)
cerr << "correlation between " << it.name << " and " << it.name2;
else // either a parameter, the stderr of an exo, or the measurement error of an endo
cerr << "symbol " << it.name;
cerr << ". This behaviour is undefined." << endl;
exit(EXIT_FAILURE);
}
}
}
EstimatedParamsStatement::EstimatedParamsStatement(vector<EstimationParams> estim_params_list_arg,