Uses preprocessing capabilities introduced in 07137e804bFixes#392 and #494. Also fixes a bug in the checking for positive definiteness of covariance matrices in likelihood functions
Allows for calibrated covariances by reading them out and setting them after covariance matrix has been reconstructed from correlation and variances.
Adds unit test
1. The first call to set_prior overwrote the first column of
estim_params_.var_endo storing the position of the variable with
measurement error in M_.endo_names with the position in
options_.var_obs. All subsequent calls to set_prior then lead to
crashes.
2. At the same time, for correlations of ME, the first column of
estim_params_.corrn still stored the position of the variable with
measurement error in M_.endo_names. But subsequent calls to it were done
as if it stored the position in options_.var_obs
I introduced two new variables in estim_params_ storing the respective
positions in var_obs so as to not necessitate changes in the
preprocessors.
3. For cases of calibrated measurement error correlations, the
covariance matrix was not updated.
4. Fixing a lot of smaller bugs related to measurement errors, including
some copy and paste errors
-
the computation of the prior density.
bayestopt_.p1 is always the prior mean
bayestopt_.p2 is always the prior standard deviation
bayestopt_.p3 is unchanged
bayestopt_.p4 is unchanged
bayestopt_.p5 [new field] is the prior mode
bayestopt_.p6 [new field] is the first hyper-parameter of the prior density
bayestopt_.p7 [new field] is the second hyper-parameter of the prior density
These fields are defined in set_prior and are never changed after. In
the previous version of Dynare, the hyper parameters of the densities
were updated at each iteration of the optimization routine or the
metropolis.
Removed fields pmean and pstdev.
Vectorized the code in priordens.
Fixed the bug mentionned by Gianni. If a (logged) density is evaluated
outside the prior domain, the output of priordens if minus infinity
(instead of a complex number).
git-svn-id: https://www.dynare.org/svn/dynare/trunk@2556 ac1d8469-bf42-47a9-8791-bf33cf982152