From f443037ed3b06f0d5dbfe22365548458998c7675 Mon Sep 17 00:00:00 2001 From: Houtan Bastani Date: Fri, 1 Mar 2019 12:35:59 +0100 Subject: [PATCH] fix argument checking in pooled_ols --- matlab/ols/pooled_ols.m | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/matlab/ols/pooled_ols.m b/matlab/ols/pooled_ols.m index c27084a7e..f879ff657 100644 --- a/matlab/ols/pooled_ols.m +++ b/matlab/ols/pooled_ols.m @@ -45,20 +45,16 @@ if isempty(ds) || ~isdseries(ds) error('The first argument must be a dseries'); end -if isempty(param_common) && isempty(param_regex) - disp('Performing OLS instead of Pooled OLS...') - if nargin < 6 - dyn_ols(ds); - else - dyn_ols(ds, {}, eqtags); - end - return -end - if nargin < 5 eqtags = {}; end +if isempty(param_common) && isempty(param_regex) + disp('Performing OLS instead of Pooled OLS...') + dyn_ols(ds, {}, eqtags); + return +end + assert(~isempty(param_common) && iscellstr(param_common), 'The second argument must be a cellstr'); assert(~isempty(param_regex) && iscellstr(param_regex), 'The third argument must be a cellstr');