From 1db86865f70db73cb5db841ec8678e7c0fb57bd3 Mon Sep 17 00:00:00 2001 From: Marco Ratto Date: Wed, 22 Mar 2017 23:24:41 +0100 Subject: [PATCH 1/2] better trap missing input arguments --- matlab/gsa/scatter_plots.m | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/matlab/gsa/scatter_plots.m b/matlab/gsa/scatter_plots.m index a2c71eeaf..9dbd363a0 100644 --- a/matlab/gsa/scatter_plots.m +++ b/matlab/gsa/scatter_plots.m @@ -1,5 +1,4 @@ function scatter_plots(X,xp,vnames,plotsymbol, fnam, dirname, figtitle, xparam1, DynareOptions) - % % Written by Marco Ratto % Joint Research Centre, The European Commission, @@ -53,16 +52,17 @@ if nargin<4 || isempty(plotsymbol) end end -if nargin<5 - fnam=''; +if nargin<5 || isempty(fnam) + fnam='scatter_plot'; end -if nargin<6, +if nargin<6 || isempty(dirname), dirname=''; nograph=1; + DynareOptions.nodisplay=0; else nograph=0; end -if nargin<7, +if nargin<7 || isempty(figtitle), figtitle=fnam; end if nargin<8, @@ -72,10 +72,8 @@ end figtitle_tex=strrep(figtitle,'_','\_'); fig_nam_=[fnam]; -if ~nograph, hh=dyn_figure(DynareOptions,'name',figtitle); set(hh,'userdata',{X,xp}) -end bf = 0.1; ffs = 0.05/(p-1); From c60379ae96fc59a998ad61a2b84afac7f86bf1b7 Mon Sep 17 00:00:00 2001 From: Marco Ratto Date: Wed, 22 Mar 2017 23:32:19 +0100 Subject: [PATCH 2/2] upgrade call to evaluate_smoother --- matlab/gsa/scatter_callback.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/matlab/gsa/scatter_callback.m b/matlab/gsa/scatter_callback.m index 8260cdf65..84b7d9ec0 100644 --- a/matlab/gsa/scatter_callback.m +++ b/matlab/gsa/scatter_callback.m @@ -23,7 +23,7 @@ function scatter_callback(K, type) % You should have received a copy of the GNU General Public License % along with Dynare. If not, see . -global oo_ M_ +global oo_ M_ options_ bayestopt_ estim_params_ x=get(gcf,'userdata'); r2=x{1}; @@ -37,6 +37,6 @@ switch type case 'eval' disp('Evaluating smoother ...') - oo_=evaluate_smoother(xparam1,M_.endo_names); + [oo_, M_]=evaluate_smoother(xparam1,M_.endo_names,M_,oo_,options_,bayestopt_,estim_params_); % [rmse, lnam, r2,vv] = plot_fit(obsname{:}); end