stepan
/
dynare
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libkorder MEX: remove useless parameter copies and std::move calls in constructors 

Automatically detected by clang-tidy using performance-unnecessary-value-param
and performance-move-const-arg checks.
mr#2177
Sébastien Villemot 2023-12-12 18:20:11 +01:00
parent 00434c595d
commit 63d5569cf4
No known key found for this signature in database
GPG Key ID: 2CECE9350ECEBE4A
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mex/sources/libkorder/sylv/BlockDiagonal.cc
View File

@ -24,8 +24,8 @@
#include <iostream>
#include <utility>
BlockDiagonal::BlockDiagonal(ConstVector d, int d_size) :
QuasiTriangular(std::move(d), d_size), row_len(d_size), col_len(d_size)
BlockDiagonal::BlockDiagonal(const ConstVector& d, int d_size) :
QuasiTriangular(d, d_size), row_len(d_size), col_len(d_size)
{
for (int i = 0; i < d_size; i++)
{

2
mex/sources/libkorder/sylv/BlockDiagonal.hh
View File

@ -31,7 +31,7 @@ class BlockDiagonal : public QuasiTriangular
std::vector<int> row_len, col_len;
public:
BlockDiagonal(ConstVector d, int d_size);
BlockDiagonal(const ConstVector& d, int d_size);
BlockDiagonal(const BlockDiagonal& b) = default;
explicit BlockDiagonal(const QuasiTriangular& t);
BlockDiagonal&

4
mex/sources/libkorder/tl/ps_tensor.hh
View File

@ -110,8 +110,8 @@ public:
{
per.apply(nvmax);
}
PerTensorDimens(IntSequence ss, IntSequence coor) :
TensorDimens(std::move(ss), sortIntSequence(coor)), per(std::move(coor))
PerTensorDimens(const IntSequence& ss, const IntSequence& coor) :
TensorDimens(ss, sortIntSequence(coor)), per(coor)
{
per.apply(nvmax);
}